Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-43745: Add support for IdleCloseTerminationPolicy #639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-43745: Add support for IdleCloseTerminationPolicy #639

wants to merge 1 commit into from
+7 −4

Conversation

frobware
Copy link
Contributor

@frobware frobware commented Nov 19, 2024 •
edited
Loading

Replace the hard-coded idle-close-on-response setting with a conditional based on the IngressController's spec.idleConnectionTerminationPolicy field, which controls whether HAProxy maintains idle frontend connections during reloads or closes them immediately.

The default behaviour for OCP 4.19 returns to closing idle connections immediately, reversing https://issues.redhat.com/browse/OCPBUGS-32044 which had made 'option idle-close-on-response' always present in the HAProxy configuration.

References:

@frobware
Make idle-close-on-response configurable in HAProxy template
66f932a 
Replace the hard-coded idle-close-on-response setting with a conditional
based on the IngressController's spec.idleConnectionTerminationPolicy
field, which controls whether HAProxy maintains idle frontend
connections during reloads or closes them immediately.

The default behaviour returns to closing idle connections immediately,
reversing https://issues.redhat.com/browse/OCPBUGS-32044 which had made
'option idle-close-on-response' always present in the configuration.
@frobware frobware changed the title Make idle-close-on-response configurable in HAProxy template OCPBUGS-43745: Make idle-close-on-response configurable in HAProxy template Nov 19, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 19, 2024
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Jira Issue OCPBUGS-43745, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Replace the hard-coded idle-close-on-response setting with a conditional
based on the IngressController's spec.idleConnectionTerminationPolicy
field, which controls whether HAProxy maintains idle frontend
connections during reloads or closes them immediately.

The default behaviour returns to closing idle connections immediately,
reversing https://issues.redhat.com/browse/OCPBUGS-32044 which had made
'option idle-close-on-response' always present in the configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@frobware frobware marked this pull request as draft November 19, 2024 14:34
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@openshift-ci openshift-ci bot requested review from knobunc and Miciah November 19, 2024 14:36
@frobware frobware mentioned this pull request Nov 19, 2024
Open
frobware added a commit to frobware/cluster-ingress-operator that referenced this pull request Nov 19, 2024
@frobware
DO NOT MERGE: force IngressControllerImage to openshift/router#639
9b67449 
openshift/router#639
@frobware frobware mentioned this pull request Nov 21, 2024
Merged
@frobware frobware changed the title OCPBUGS-43745: Make idle-close-on-response configurable in HAProxy template OCPBUGS-43745: Add support for IdleCloseTerminationPolicy Nov 21, 2024
@frobware frobware marked this pull request as ready for review November 21, 2024 07:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@openshift-ci openshift-ci bot requested review from candita and rfredette November 21, 2024 07:43
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024 •
edited
Loading

@frobware: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 66f932a link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alebedev87
Copy link
Contributor

/assign

@candita
Copy link
Contributor

candita commented Dec 11, 2024

/assign @grzpiotrowski

@frobware
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 19, 2024
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Jira Issue OCPBUGS-43745, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lihongan December 19, 2024 10:23
grzpiotrowski
grzpiotrowski reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@grzpiotrowski grzpiotrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Leaving the final approve to @alebedev87

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@alebedev87
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
@grzpiotrowski
Copy link
Contributor

Looks like we need the acknowledge-critical-fixes-only label for it to move

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzpiotrowski grzpiotrowski grzpiotrowski left review comments

@knobunc knobunc Awaiting requested review from knobunc

@Miciah Miciah Awaiting requested review from Miciah

@candita candita Awaiting requested review from candita

@rfredette rfredette Awaiting requested review from rfredette

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@alebedev87 alebedev87

@grzpiotrowski grzpiotrowski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frobware @openshift-ci-robot @alebedev87 @candita @grzpiotrowski